Skip to content

Passing host DNS to corectld.#21

Closed
TheIndifferent wants to merge 2 commits into
TheNewNormal:masterfrom
TheIndifferent:master
Closed

Passing host DNS to corectld.#21
TheIndifferent wants to merge 2 commits into
TheNewNormal:masterfrom
TheIndifferent:master

Conversation

@TheIndifferent
Copy link
Copy Markdown

Needed change when there is internal registry instance in the office network and internal DNS is needed to resolve its hostname. Maybe that change will look better inside corectld itself, but will take me way more time to learn go and do it, while I want to use CoreOS.app already.

@rimusz
Copy link
Copy Markdown
Member

rimusz commented Jul 19, 2016

@AntonioMeireles what do think, keep it in corectl.app or you can make that in corectld directly?

@AntonioMeireles
Copy link
Copy Markdown
Member

Hi @TheIndifferent
Thanks !!! ... one case where this isn't going to work smothly, as is, is when the user has previously a local nameserver running in his mac host . corectld wouldn't start anyway as :53 would be binded already but nevertherless for this to be rock-solid the ideal is to exclude in printLocalDns the host itself. Can you look at handling that ?

thanks again!

@TheIndifferent
Copy link
Copy Markdown
Author

Sure. To make sure I understand what you mean, if there is already a local DNS running on 127.0.0.1:53 on host machine then --recursive-nameservers should not be passed to corectld?

@AntonioMeireles
Copy link
Copy Markdown
Member

if there is a local DNS server running on :53 (any IP/interface on localhost) it should not be passed. PLease do note that in this scenario corectld will fail to start anyway.

@TheIndifferent
Copy link
Copy Markdown
Author

👍 got it

@TheIndifferent
Copy link
Copy Markdown
Author

Ok, changes implemented, tested, works well so far. But noticed interesting issue, when I start the laptop it takes couple more seconds for wifi to establish the connection and for resolv.conf to be updated, in the meantime corectld starts with google dns parameters. So after resolv.conf is updated I have to restart corectl.app to pick up new DNS servers. No idea if it is possible to monitor from go and if corectld could do it dynamically.

@rimusz
Copy link
Copy Markdown
Member

rimusz commented Jul 20, 2016

I will leave it for @AntonioMeireles to check it out

@rimusz
Copy link
Copy Markdown
Member

rimusz commented Jul 26, 2016

this one is going to be taken care at corectl #88 closing

@rimusz rimusz closed this Jul 26, 2016
@AntonioMeireles
Copy link
Copy Markdown
Member

@rimuz,

reopening (due to TheNewNormal/corectl#88 (comment)). It's fixed in corectl side. UI needs a way to allow setting of the custom --recursive-nameservers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants